Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754948Ab3I3JGT (ORCPT ); Mon, 30 Sep 2013 05:06:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53724 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368Ab3I3JGS (ORCPT ); Mon, 30 Sep 2013 05:06:18 -0400 Date: Mon, 30 Sep 2013 11:08:50 +0200 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID when the codec is not known In-Reply-To: <201309272028.03764.linux@rainbow-software.org> References: <201309272028.03764.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 44 At Fri, 27 Sep 2013 20:28:03 +0200, Ondrej Zary wrote: > > Currently, if the codec ID is not known, the last byte of the ID is used as name. > It's not helpful at all, use full codec ID instead. The full bytes are already shown at the beginning, no? It's masked because the upper three bytes are shown in printable form, and the last byte is usually a model number. Takashi > > Signed-off-by: Ondrej Zary > --- > sound/pci/ac97/ac97_codec.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c > index bf578ba2..30a40a8 100644 > --- a/sound/pci/ac97/ac97_codec.c > +++ b/sound/pci/ac97/ac97_codec.c > @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, unsigned int id, char *name, int m > pid->patch(ac97); > } > } else > - sprintf(name + strlen(name), " id %x", id & 0xff); > + sprintf(name + strlen(name), " id %x", id); > } > > /** > -- > Ondrej Zary > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/