Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323Ab3I3LwV (ORCPT ); Mon, 30 Sep 2013 07:52:21 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:54954 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011Ab3I3LwT (ORCPT ); Mon, 30 Sep 2013 07:52:19 -0400 MIME-Version: 1.0 In-Reply-To: <20130930110125.GY19304@sirena.org.uk> References: <1380531434-15875-1-git-send-email-sachin.kamat@linaro.org> <20130930110125.GY19304@sirena.org.uk> Date: Mon, 30 Sep 2013 17:22:19 +0530 Message-ID: Subject: Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr From: Sachin Kamat To: Mark Brown Cc: LKML , Liam Girdwood Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 21 On 30 September 2013 16:31, Mark Brown wrote: > On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote: > > Note that one of the things these macros are supposed to do (but don't > yet IIRC) is allow for dead code elimination to discard references to > things automatically even without the being ifdefed out. Yes that is correct. However, in this particular case all that of_match_ptr() does is make the pointer NULL if CONFIG_OF is disabled else assign it as is. Since CONFIG_OF is not used in these files, I thought it would be an appropriate cleanup. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/