Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755748Ab3I3OYo (ORCPT ); Mon, 30 Sep 2013 10:24:44 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:43732 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755719Ab3I3OYm (ORCPT ); Mon, 30 Sep 2013 10:24:42 -0400 Date: Mon, 30 Sep 2013 10:24:41 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Bartlomiej Zolnierkiewicz cc: Len Brown , Pavel Machek , "Rafael J. Wysocki" , , , Kyungmin Park Subject: Re: [PATCH] x86/acpi: fix incorrect placement of __initdata tag In-Reply-To: <12346908.30tngvOZuc@amdc1032> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 35 On Mon, 30 Sep 2013, Bartlomiej Zolnierkiewicz wrote: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. The line you are changing does not have an equals sign. Therefore, according to your own patch description, the patch is incorrect. :-) > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > arch/x86/kernel/acpi/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > index 1f7c074..6c0b43b 100644 > --- a/arch/x86/kernel/acpi/boot.c > +++ b/arch/x86/kernel/acpi/boot.c > @@ -695,7 +695,7 @@ static int __init acpi_parse_sbf(struct acpi_table_header *table) > #ifdef CONFIG_HPET_TIMER > #include > > -static struct __initdata resource *hpet_res; > +static struct resource *hpet_res __initdata; > > static int __init acpi_parse_hpet(struct acpi_table_header *table) > { Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/