Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802Ab3I3PFW (ORCPT ); Mon, 30 Sep 2013 11:05:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30698 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754211Ab3I3PFS (ORCPT ); Mon, 30 Sep 2013 11:05:18 -0400 Date: Mon, 30 Sep 2013 17:59:39 +0300 From: Dan Carpenter To: Jiri Kosina Cc: Joseph Salisbury , list@osuosl.org, Haiyang Zhang , LKML , open@osuosl.org, HID CORE LAYER , devel@linuxdriverproject.org, thomas@m3y3r.de Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Message-ID: <20130930145939.GK6192@mwanda> References: <20130916203824.GP25896@mwanda> <52376ED9.5080208@canonical.com> <20130916210503.GQ25896@mwanda> <5237A5D5.8010006@canonical.com> <52432152.3030100@canonical.com> <52459942.3020600@canonical.com> <20130927152412.GF6192@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 809 Lines: 24 On Mon, Sep 30, 2013 at 04:35:47PM +0200, Jiri Kosina wrote: > On Fri, 27 Sep 2013, Dan Carpenter wrote: > > > It looks like magicmouse_raw_event() returns 1 on success and 0 on > > failure. > > Good catch indeed. > > I am not completely sure whether we are going to fix an oops or not by > this, as I haven't seen the actual oops anywhere in this thread :) But > definitely this looks like a good fix. > > Joseph, could you please test with that? Thanks. In the new code both 0 and 1 are treated the same so this can't fix the bug. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/