Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756584Ab3I3U3T (ORCPT ); Mon, 30 Sep 2013 16:29:19 -0400 Received: from mga03.intel.com ([143.182.124.21]:45245 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756421Ab3I3U3P (ORCPT ); Mon, 30 Sep 2013 16:29:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,1010,1371106800"; d="scan'208";a="367903923" From: Andi Kleen To: linux-kernel@vger.kernel.org Cc: Andi Kleen , axboe@kernel.dk Subject: [PATCH 04/11] block: Return error code of elevator init function Date: Mon, 30 Sep 2013 13:29:05 -0700 Message-Id: <1380572952-30729-5-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1380572952-30729-1-git-send-email-andi@firstfloor.org> References: <1380572952-30729-1-git-send-email-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 40 From: Andi Kleen The error code was ignored, which I assume is a mistake. Cc: axboe@kernel.dk Signed-off-by: Andi Kleen --- block/elevator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index 2bcbd8c..6c2a8ee 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -184,7 +184,6 @@ static void elevator_release(struct kobject *kobj) int elevator_init(struct request_queue *q, char *name) { struct elevator_type *e = NULL; - int err; if (unlikely(q->elevator)) return 0; @@ -222,8 +221,7 @@ int elevator_init(struct request_queue *q, char *name) } } - err = e->ops.elevator_init_fn(q, e); - return 0; + return e->ops.elevator_init_fn(q, e); } EXPORT_SYMBOL(elevator_init); -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/