Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756060Ab3I3VfS (ORCPT ); Mon, 30 Sep 2013 17:35:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42954 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754855Ab3I3VfQ (ORCPT ); Mon, 30 Sep 2013 17:35:16 -0400 Date: Mon, 30 Sep 2013 14:35:14 -0700 From: Andrew Morton To: Joonsoo Kim Cc: Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton Subject: Re: [PATCH] mm, hugetlb: correct missing private flag clearing Message-Id: <20130930143514.63fc5b2b4316caed33e1c1b1@linux-foundation.org> In-Reply-To: <1380527985-18499-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1380527985-18499-1-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 38 On Mon, 30 Sep 2013 16:59:44 +0900 Joonsoo Kim wrote: > We should clear the page's private flag when returing the page to > the page allocator or the hugepage pool. This patch fixes it. > > Signed-off-by: Joonsoo Kim > --- > Hello, Andrew. > > I sent the new version of commit ('07443a8') before you did pull request, > but it isn't included. It may be losted :) > So I send this fix. IMO, this is good for v3.12. > > Thanks. > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index b49579c..691f226 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -653,6 +653,7 @@ static void free_huge_page(struct page *page) > BUG_ON(page_count(page)); > BUG_ON(page_mapcount(page)); > restore_reserve = PagePrivate(page); > + ClearPagePrivate(page); > You describe it as a fix, but what does it fix? IOW, what are the user-visible effects of the change? update_and_free_page() already clears PG_private, but afaict the bit remains unaltered if free_huge_page() takes the enqueue_huge_page() route. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/