Message-ID: <1380653008.1924.10.camel@joe-AO722>
Subject: Re: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
From: Joe Perches <joe@perches.com>
To: OS Engineering <osengineering@stec-inc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
        Akhil Bhansali <Akhil.Bhansali@hgst.com>,
        "jmoyer@redhat.com" <jmoyer@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Amit Phansalkar <Amit.Phansalkar@hgst.com>,
        Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>
Date: Tue, 01 Oct 2013 11:43:28 -0700
In-Reply-To: <26D762E250385C4D8E9D6EC3C8E47DC11E70588B@sambx4.stec-inc.ad>
References: <26D762E250385C4D8E9D6EC3C8E47DC11E70588B@sambx4.stec-inc.ad>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 33

On Tue, 2013-10-01 at 12:29 +0000, OS Engineering wrote:
> From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
> From: rchinthekindi <rchinthekindi@stec-inc.com>
> Date: Tue, 1 Oct 2013 17:49:58 +0530
> Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
> 
> Restricted pr_debug() lines to 80 characters

Please don't split formats across multiple lines.

> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c


> @@ -2370,9 +2372,10 @@ static void skd_complete_internal(struct skd_device *skdev,
>  			skd_send_internal_skspcl(skdev, skspcl, WRITE_BUFFER);
>  		else {
>  			if (skdev->state == SKD_DRVR_STATE_STOPPING) {
> -				pr_debug("%s:%s:%d TUR failed, don't send anymore"
> -					 "state 0x%x\n",
> -					 skdev->name, __func__, __LINE__, skdev->state);
> +				pr_debug("%s:%s:%d TUR failed, don't send"
> +					 " anymore state 0x%x\n",
> +					 skdev->name, __func__, __LINE__,
> +					 skdev->state);

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/