Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254Ab3JAVEk (ORCPT ); Tue, 1 Oct 2013 17:04:40 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:40536 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881Ab3JAVEi convert rfc822-to-8bit (ORCPT ); Tue, 1 Oct 2013 17:04:38 -0400 Date: Tue, 1 Oct 2013 16:04:31 -0500 From: Seth Jennings To: Krzysztof Kozlowski Cc: Tomasz Stanislawski , Bob Liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Kyungmin Park , Dave Hansen , Minchan Kim Subject: Re: [PATCH v2 0/5] mm: migrate zbud pages Message-ID: <20131001210431.GA8941@variantweb.net> References: <1378889944-23192-1-git-send-email-k.kozlowski@samsung.com> <5237FDCC.5010109@oracle.com> <20130923220757.GC16191@variantweb.net> <524318DE.7070106@samsung.com> <20130925215744.GA25852@variantweb.net> <52455B05.1010603@samsung.com> <20130927220045.GA751@variantweb.net> <1380529726.11375.11.camel@AMDC1943> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1380529726.11375.11.camel@AMDC1943> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13100121-5806-0000-0000-000022EBB220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5535 Lines: 144 On Mon, Sep 30, 2013 at 10:28:46AM +0200, Krzysztof Kozlowski wrote: > On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: > > I have to say that when I first came up with the idea, I was thinking > > the address space would be at the zswap layer and the radix slots would > > hold zbud handles, not struct page pointers. > > > > However, as I have discovered today, this is problematic when it comes > > to reclaim and migration and serializing access. > > > > I wanted to do as much as possible in the zswap layer since anything > > done in the zbud layer would need to be duplicated in any other future > > allocator that zswap wanted to support. > > > > Unfortunately, zbud abstracts away the struct page and that visibility > > is needed to properly do what we are talking about. > > > > So maybe it is inevitable that this will need to be in the zbud code > > with the radix tree slots pointing to struct pages after all. > > To me it looks very similar to the solution proposed in my patches. Yes, it is very similar. I'm beginning to like aspects of this patch more as I explore this issue more. At first, I balked at the idea of yet another abstraction layer, but it is very hard to avoid unless you want to completely collapse zswap and zbud into one another and dissolve the layering. Then you could do a direct swap_offset -> address mapping. > The > difference is that you wish to use offset as radix tree index. > I thought about this earlier but it imposed two problems: > > 1. A generalized handle (instead of offset) may be more suitable when > zbud will be used in other drivers (e.g. zram). > > 2. It requires redesigning of zswap architecture around > zswap_frontswap_store() in case of duplicated insertion. Currently when > storing a page the zswap: > - allocates zbud page, > - stores new data in it, > - checks whether it is a duplicated page (same offset present in > rbtree), > - if yes (duplicated) then zswap frees previous entry. > The problem here lies in allocating zbud page under the same offset. > This step would replace old data (because we are using the same offset > in radix tree). Yes, but the offset is always going to be the key at the top layer because that is was the swap subsystem uses. So we'd have to have a swap_offset -> handle -> address translation (2 abstraction layers) the first of which would need to deal with the duplicate store issue. Seth > > In my opinion using zbud handle is in this case more flexible. > > > Best regards, > Krzysztof > > > I like the idea of masking the bit into the struct page pointer to > > indicate which buddy maps to the offset. > > > > There is a twist here in that, unlike a normal page cache tree, we can > > have two offsets pointing at different buddies in the same frame > > which means we'll have to do some custom stuff for migration. > > > > The rabbit hole I was going down today has come to an end so I'll take a > > fresh look next week. > > > > Thanks for your ideas and discussion! Maybe we can make zswap/zbud an > > upstanding MM citizen yet! > > > > Seth > > > > > > > > >> > > > >> In case of zbud, there are two swap offset pointing to > > > >> the same page. There might be more if zsmalloc is used. > > > >> What is worse it is possible that one swap entry could > > > >> point to data that cross a page boundary. > > > > > > > > We just won't set page->index since it doesn't have a good meaning in > > > > our case. Swap cache pages also don't use index, although is seems to > > > > me that they could since there is a 1:1 mapping of a swap cache page to > > > > a swap offset and the index field isn't being used for anything else. > > > > But I digress... > > > > > > OK. > > > > > > > > > > >> > > > >> Of course, one could try to modify MM to support > > > >> multiple mapping of a page in the radix tree. > > > >> But I think that MM guys will consider this as a hack > > > >> and they will not accept it. > > > > > > > > Yes, it will require some changes to the MM to handle zbud pages on the > > > > LRU. I'm thinking that it won't be too intrusive, depending on how we > > > > choose to mark zbud pages. > > > > > > > > > > Anyway, I think that zswap should use two index engines. > > > I mean index in Data Base meaning. > > > One index is used to translate swap_entry to compressed page. > > > And another one to be used by reclaim and migration by MM, > > > probably address_space is a best choice. > > > Zbud would responsible for keeping consistency > > > between mentioned indexes. > > > > > > Regards, > > > Tomasz Stanislawski > > > > > > > Seth > > > > > > > >> > > > >> Regards, > > > >> Tomasz Stanislawski > > > >> > > > >> > > > >>> -- > > > >>> To unsubscribe, send a message with 'unsubscribe linux-mm' in > > > >>> the body to majordomo@kvack.org. For more info on Linux MM, > > > >>> see: http://www.linux-mm.org/ . > > > >>> Don't email: email@kvack.org > > > >>> > > > >> > > > > > > > > -- > > > > To unsubscribe, send a message with 'unsubscribe linux-mm' in > > > > the body to majordomo@kvack.org. For more info on Linux MM, > > > > see: http://www.linux-mm.org/ . > > > > Don't email: email@kvack.org > > > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/