Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266Ab3JAVJQ (ORCPT ); Tue, 1 Oct 2013 17:09:16 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:41976 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024Ab3JAVJN (ORCPT ); Tue, 1 Oct 2013 17:09:13 -0400 MIME-Version: 1.0 In-Reply-To: <524B3538.9010406@zytor.com> References: <1380656245-29975-1-git-send-email-keescook@chromium.org> <1380656245-29975-2-git-send-email-keescook@chromium.org> <524B3538.9010406@zytor.com> Date: Tue, 1 Oct 2013 14:09:12 -0700 X-Google-Sender-Auth: fDlm9X4fceIawk_1c1RkoE3N14k Message-ID: Subject: Re: [PATCH 1/7] x86, kaslr: move CPU flags out of cpucheck From: Kees Cook To: "H. Peter Anvin" Cc: LKML , "x86@kernel.org" , "kernel-hardening@lists.openwall.com" , Aaron Durbin , Eric Northup , Julien Tinnes , Will Drewry , Mathias Krause , Zhang Yanfei Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 29 On Tue, Oct 1, 2013 at 1:48 PM, H. Peter Anvin wrote: > On 10/01/2013 12:37 PM, Kees Cook wrote: >> Refactor the CPU flags handling out of the cpucheck routines so that >> they can be reused by the future ASLR routines (in order to detect CPU >> features like RDRAND and RDTSC). >> >> This reworks has_eflag() and has_fpu() to be used on both 32-bit and >> 64-bit, and refactors the calls to cpuid to make them PIC-safe on 32-bit. >> >> Signed-off-by: Kees Cook > > Please flag the ones that specifically touch the boot code so that is > clear. Neither the title or the description makes that at all clear, > and at first reading is fairly confusing as a result. Yes, good point. Patch 1/7 should be named "x86, boot: ..." Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/