Message-ID: <524B3CD5.3030904@hurleysoftware.com>
Date: Tue, 01 Oct 2013 17:21:25 -0400
From: Peter Hurley <peter@hurleysoftware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Linux kernel <linux-kernel@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: 3.12.0-rc3: Symbol license change in commit caf5c03f (ACPI: Move
 acpi_bus_get_device() from bus.c to scan.c)
References: <524AFF89.4080703@hurleysoftware.com> <5459219.RfezHuQcWu@vostro.rjw.lan>
In-Reply-To: <5459219.RfezHuQcWu@vostro.rjw.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1528
Lines: 44

On 10/01/2013 05:00 PM, Rafael J. Wysocki wrote:
> On Tuesday, October 01, 2013 12:59:53 PM Peter Hurley wrote:
>> I have no love lost for proprietary modules but changing
>> acpi_bus_get_device() symbol's license seems gratuitous considering
>> the symbol pre-dates the mainline git tree and the code is just
>> being moved from one source file to another.
>
> Well, I didn't know whether or not any binary modules use that function in the
> first place.
>
> It looks like some of them do, so below is a revert of that change (that I'm
> going to push for -rc4).
>
> I wonder what module exactly you have in mind, though?

For 3.12, the nouveau driver wants to use MSIs by default.
Unfortunately, some hardware which should support it doesn't.

The binary driver recently migrated to MSIs by default as well,
so I was testing to see if the hardware could run stably with that
driver with MSIs on (since I don't use the binary driver, I needed to
experiment).

Switching back and forth between the drivers is really error-prone;
instead, I sacrificed an older partition/userspace, where I confirmed
that the binary driver does run stably with MSIs -- on kernel 3.2.x.

When I tried to repeat the testing on 3.12-rc2 & -rc3, I happened
upon this change.

Regards,
Peter Hurley


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/