Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989Ab3JAWrp (ORCPT ); Tue, 1 Oct 2013 18:47:45 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:57329 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479Ab3JAWrm (ORCPT ); Tue, 1 Oct 2013 18:47:42 -0400 Date: Tue, 1 Oct 2013 17:46:47 -0500 From: Nishanth Menon To: Eduardo Valentin CC: , , , , , , , , , , , Subject: Re: [PATCH 3/7] arm: dts: dra7: add bandgap entry Message-ID: <20131001224645.GC11451@kahuna> References: <1380652344-18819-1-git-send-email-eduardo.valentin@ti.com> <1380652344-18819-4-git-send-email-eduardo.valentin@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1380652344-18819-4-git-send-email-eduardo.valentin@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 44 On 14:32-20131001, Eduardo Valentin wrote: > This patch adds bandgap IP entry on DRA7 dtsi device tree file. > > Signed-off-by: Eduardo Valentin > --- > arch/arm/boot/dts/dra7.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 3a746c2..4e9b159 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -53,6 +53,18 @@ > }; > }; > > + bandgap: bandgap { would you like to follow bandgap: bandgap@4a0021e0 convention? Also, could you move it under ocp? I already commented about this previously here: https://lkml.org/lkml/2013/9/27/300 > + reg = <0x4a0021e0 0xc > + 0x4a00232c 0xc > + 0x4a002380 0x2c > + 0x4a0023C0 0x3c > + 0x4a002564 0x8 > + 0x4a002574 0x50>; > + compatible = "ti,dra752-bandgap"; > + interrupts = ; > + #thermal-sensor-cells = <1>; > + }; > + > gic: interrupt-controller@48211000 { > compatible = "arm,cortex-a15-gic"; > interrupt-controller; -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/