Message-ID: <1380681356.14271.57.camel@ul30vt.home>
Subject: Re: RFC: (re-)binding the VFIO platform driver to a platform device
From: Alex Williamson <alex.williamson@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Kim Phillips <kim.phillips@linaro.org>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, a.motakis@virtualopensystems.com,
        agraf@suse.de, stuart.yoder@freescale.com, B07421@freescale.com,
        B16395@freescale.com, R65777@freescale.com, peter.maydell@linaro.org,
        santosh.shukla@linaro.org, kvm@vger.kernel.org
Date: Tue, 01 Oct 2013 20:35:56 -0600
In-Reply-To: <20131002015355.GD63102@lvm>
References: <20131001133831.6e46e8e00e09d5d9079fde57@linaro.org>
	 <20131001200054.GA27330@kroah.com>
	 <20131001170244.ff4fb81d9a7a09598c4c6247@linaro.org>
	 <20131002015355.GD63102@lvm>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2841
Lines: 60

On Wed, 2013-10-02 at 02:53 +0100, Christoffer Dall wrote:
> On Tue, Oct 01, 2013 at 05:02:44PM -0500, Kim Phillips wrote:
> > On Tue, 1 Oct 2013 13:00:54 -0700
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > > On Tue, Oct 01, 2013 at 01:38:31PM -0500, Kim Phillips wrote:
> > > > Hi,
> > > > 
> > > > Santosh and I are having a problem figuring out how to enable binding
> > > > (and re-binding) platform devices to a platform VFIO driver (see
> > > > Antonis' WIP: [1]) in an upstream-acceptable manner.
> > > > 
> > > > Binding platform drivers currently depends on a string match in the
> > > > device node's compatible entry.  On an arndale, one can currently
> > > > rebind the same device to the same driver like so:
> > > > 
> > > > echo 12ce0000.i2c > /sys/bus/platform/drivers/s3c-i2c/12ce0000.i2c/driver/unbind
> > > > echo 12ce0000.i2c > /sys/bus/platform/drivers/s3c-i2c/bind
> > > > 
> > > > And one can bind it to the vfio-dt driver, as Antonis instructs, by
> > > > appending a 'vfio-dt' string to the device tree compatible entry for
> > > > the device.  Then this would work:
> > > > 
> > > > echo 12ce0000.i2c > /sys/bus/platform/drivers/s3c-i2c/12ce0000.i2c/driver/unbind
> > > > echo 12ce0000.i2c > /sys/bus/platform/drivers/vfio-dt/bind
> > > > 
> > > > Consequently, the hack patch below [2] allows any platform device to be
> > > > bound to the vfio-dt driver, without making changes to the device
> > > > tree.  It's a hack because I don't see having any driver name specific
> > > > code in drivers/base/bus.c being upstream acceptable.
> > > 
> > > You are correct.
> > > 
> > > What is wrong with just doing the above unbind/bind things through
> > > sysfs, that is what it is there for, right?
> > 
> > The bind fails because the compatible string in the device tree doesn't
> > match that of the VFIO platform driver, so driver_match_device always
> > returns false.
> > 
> It sounds like this is not going to be pretty almost no matter what
> we'll end up doing: Inherently VFIO is going to bind to a device without
> the device tree entry for that device ever saying anything about VFIO.
> 
> How is this solved for PCI?  Can we use some analogy from that work to
> construct the missing piece?

PCI supports a dynamic ID table for driver/device matching, see
pci_add_dynid().  The problem is that this gets a little sloppy for the
period where you have multiple drivers that can claim the same device,
especially in the presence of hotplug.  Thus the desire to improve the
situation with some kind of direct binding interface.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/