Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104Ab3JBHFY (ORCPT ); Wed, 2 Oct 2013 03:05:24 -0400 Received: from p-mail1.rd.orange.com ([195.101.245.15]:25208 "EHLO p-mail1.rd.orange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743Ab3JBHFV (ORCPT ); Wed, 2 Oct 2013 03:05:21 -0400 X-Greylist: delayed 443 seconds by postgrey-1.27 at vger.kernel.org; Wed, 02 Oct 2013 03:05:20 EDT From: "Yann E. MORIN" To: Dirk Gouders Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner Date: Wed, 2 Oct 2013 08:57:54 +0200 User-Agent: KMail/1.13.5 (Linux/3.10.11-ilmarinen-nv; KDE/4.4.5; x86_64; ; ) Cc: Martin Walch , Michal Marek , Jiri Kosina , Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= , Benjamin Poirier , Wang YanQing , Andrew Morton , Jean Delvare , Kees Cook , Alan Cox , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org References: <6249343.9Mjtul3lu5@tacticalops> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201310020857.54800.yann.morin.1998@free.fr> X-OriginalArrivalTime: 02 Oct 2013 06:57:55.0538 (UTC) FILETIME=[B88AF320:01CEBF3C] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1894 Lines: 56 Martin, All, On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote: > Martin Walch writes: > > > From: Martin Walch > > Date: Wed, 2 Oct 2013 06:58:46 +0200 > > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner > > > > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion. > > Hi Martin, > > I think you should also regenerate the scanner and add > the new zconf.lex.c_shipped to this patch. I think sending the re-generated parser as a separate patch helps in reviewing. Ie. I'd prefer a fifth patch. BTW, regenerating the parser can be done with: make REGENERATE_PARSERS=1 config Regards, Yann E. MORIN. > > Signed-off-by: Martin Walch > > --- > > scripts/kconfig/zconf.l | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l > > index 6555a47..1a9f53e 100644 > > --- a/scripts/kconfig/zconf.l > > +++ b/scripts/kconfig/zconf.l > > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size) > > } > > %} > > > > -ws [ \n\t] > > n [A-Za-z0-9_] > > > > %% > -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | '------------------------------'-------'------------------'--------------------' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/