Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754471Ab3JBVIx (ORCPT ); Wed, 2 Oct 2013 17:08:53 -0400 Received: from mail-bk0-f53.google.com ([209.85.214.53]:53855 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405Ab3JBVIu (ORCPT ); Wed, 2 Oct 2013 17:08:50 -0400 MIME-Version: 1.0 In-Reply-To: <20131002114359.681cbdf92bd683373f07cca2@linaro.org> References: <1380712124-20666-1-git-send-email-taras.kondratiuk@linaro.org> <20131002114359.681cbdf92bd683373f07cca2@linaro.org> Date: Thu, 3 Oct 2013 00:08:49 +0300 Message-ID: Subject: Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler From: Taras Kondratiuk To: Kim Phillips Cc: sameo@linux.intel.com, lee.jones@linaro.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Linaro Networking , d.xie@sta.samsung.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 33 On 2 October 2013 19:43, Kim Phillips wrote: > On Wed, 2 Oct 2013 14:08:44 +0300 > Taras Kondratiuk wrote: > >> From: Danke Xie >> >> The current TWL 6030 IRQ handler assumes little endianness. >> This change makes it endian-neutral. >> >> Signed-off-by: Danke Xie >> Signed-off-by: Taras Kondratiuk >> --- > > this patch causes a new sparse warning: > > make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o > ... > CHECK drivers/mfd/twl6030-irq.c > drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32 > > does int_sts in the sts union need to be defined as __le32? You are right. I will update the patch. -- Regards, Taras Kondratiuk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/