Date: Thu, 3 Oct 2013 03:50:07 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [rfc] rework aio migrate pages to use aio fs
Message-ID: <20131003025007.GC13318@ZenIV.linux.org.uk>
References: <20130913165937.GL2517@kvack.org>
 <20130913184204.GS13318@ZenIV.linux.org.uk>
 <20130917141825.GF11526@kvack.org>
 <20131003022251.GB13318@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131003022251.GB13318@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 31

On Thu, Oct 03, 2013 at 03:22:51AM +0100, Al Viro wrote:
> > +	/*
> > +	 * Link the inode to a directory entry by creating a unique name
> > +	 * using the inode sequence number.
> > +	 */
> > +	file = ERR_PTR(-ENOMEM);
> > +	this.name = name;
> > +	this.len = strlen(name);
> > +	this.hash = 0;
> 
> Umm...  ITYM
> 	struct qstr this = QSTR_INIT("[aio]", 5);
> , if not
> 	path.dentry = d_alloc_pseudo(aio_mnt->mnt_sb,
> 				     &(struct qstr)QSTR_INIT("[aio]", 5));
> > +	if (!path.dentry)
> > +		goto err_module;

and you've leaked that inode, BTW.

Another thing: I'd rather pull everything about setting the inode
up (aops, size, etc.) in there.

Anyway, could you take a look at the last couple of commits in
vfs.git#for-bcrl?  Commit message on the last one is an atrocity,
of course...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/