Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S264811AbSJVRay>; Tue, 22 Oct 2002 13:30:54 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S264814AbSJVRay>; Tue, 22 Oct 2002 13:30:54 -0400
Received: from pheriche.sun.com ([192.18.98.34]:55231 "EHLO pheriche.sun.com")
	by vger.kernel.org with ESMTP id <S264811AbSJVRax>;
	Tue, 22 Oct 2002 13:30:53 -0400
Message-ID: <3DB58CBD.3030207@sun.com>
Date: Tue, 22 Oct 2002 10:37:01 -0700
From: Tim Hockin <thockin@sun.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020827
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: Linus Torvalds <torvalds@transmeta.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BK PATCH 1/4] fix NGROUPS hard limit (resend)
References: <200210220036.g9M0aP831358@scl2.sfbay.sun.com>	<1035280294.31917.19.camel@irongate.swansea.linux.org.uk> 	<3DB58A47.4020404@sun.com> <1035308740.31873.107.camel@irongate.swansea.linux.org.uk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1184
Lines: 35

Alan Cox wrote:
> On Tue, 2002-10-22 at 18:26, Tim Hockin wrote:
> 
>>Alan Cox wrote:
>>
>>>Ok sanity check time. Why do you need qsort and bsearch for this kind of
>>>thing. Just how many groups do you plan to support ?
>>
>>Unlimited - we've tested with tens of thousands.
> 
> 
> Now how about the real world requirements ?

Those were real world requirements - we got the number 10,000 from our 
product management, which (presumably) spoke with customers.  On the 
hosting systems, it is really possible to have thousands of virtual sites.

Now, I don't much care if you want it to be a linear search, and I'll 
revert it, if needed, but qsort() is already in in XFS specific code, 
and bsearch is small.  It doesn't negatively impact any fast path, and 
provides better behavior for the crazies that really want 10,000 groups.

Tim

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Linux Kernel Engineering
thockin@sun.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/