Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017Ab3JCGQ5 (ORCPT ); Thu, 3 Oct 2013 02:16:57 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:55544 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754777Ab3JCGQ4 (ORCPT ); Thu, 3 Oct 2013 02:16:56 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault() From: Xiao Guangrong In-Reply-To: <20130930212308.GA31805@amt.cnet> Date: Thu, 3 Oct 2013 14:16:49 +0800 Cc: Xiao Guangrong , gleb@redhat.com, avi.kivity@gmail.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <1378376958-27252-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <1378376958-27252-3-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <20130930212308.GA31805@amt.cnet> To: Marcelo Tosatti X-Mailer: Apple Mail (2.1510) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 36 On Oct 1, 2013, at 5:23 AM, Marcelo Tosatti wrote: >> > > Unrelated to this patch: > > If vcpu->mode = OUTSIDE_GUEST_MODE, no IPI is sent > by kvm_flush_remote_tlbs. Yes. > > So how is this supposed to work again? > > /* > * Wait for all vcpus to exit guest mode and/or lockless shadow > * page table walks. > */ On the lockless walking path, we change the vcpu->mode to READING_SHADOW_PAGE_TABLES, so that IPI is needed. Or i missed your question? > kvm_flush_remote_tlbs(kvm); > > Patch looks fine. Thank you, Marcelo! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/