Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710Ab3JCHGa (ORCPT ); Thu, 3 Oct 2013 03:06:30 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:57543 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121Ab3JCHG3 (ORCPT ); Thu, 3 Oct 2013 03:06:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1380370138-3513-1-git-send-email-sachin.kamat@linaro.org> <1380370138-3513-11-git-send-email-sachin.kamat@linaro.org> Date: Thu, 3 Oct 2013 12:36:28 +0530 Message-ID: Subject: Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr From: Sachin Kamat To: Viresh Kumar Cc: Linux Kernel Mailing List , Linus Walleij Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1781 Lines: 50 On 3 October 2013 10:07, Viresh Kumar wrote: > On 28 September 2013 17:38, Sachin Kamat wrote: >> The data structure of_match_ptr() protects is always compiled in. > > of_match_ptr() isn't a data structure.. Yes you are right. of_match_ptr() is a macro. The data structure here refers to its argument and not of_match_ptr() itself. >And also what does "protects" mean here? It just means that of_match_ptr() avoids an undefined reference error had CONFIG_OF been used around the data structures definition by making the pointer NULL. > >> Hence of_match_ptr() is not needed. >> >> Signed-off-by: Sachin Kamat >> Cc: Viresh Kumar >> --- >> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c >> index 0a7f0bdb..ff2940e 100644 >> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c >> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c >> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = { >> .owner = THIS_MODULE, >> .name = "spear-plgpio", >> .pm = &plgpio_dev_pm_ops, >> - .of_match_table = of_match_ptr(plgpio_of_match), >> + .of_match_table = plgpio_of_match, >> }, >> }; > > Patch is okay otherwise. Hope to have your ack on this :) Thanks for reviewing. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/