Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728Ab3JCJOe (ORCPT ); Thu, 3 Oct 2013 05:14:34 -0400 Received: from [207.46.163.24] ([207.46.163.24]:6149 "EHLO co9outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753551Ab3JCJOa (ORCPT ); Thu, 3 Oct 2013 05:14:30 -0400 X-Forefront-Antispam-Report: CIP:62.221.5.235;KIP:(null);UIP:(null);IPV:NLI;H:xir-gw1;RD:unknown-62-221-5-235.ipspace.xilinx.com;EFVD:NLI X-SpamScore: 2 X-BigFish: VPS2(zzbb2dI98dI9371I1432I4015Idbb0izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1d7338h1de098h177df4h17326ah1de097h186068h8275bh8275dhz2fh95h839h947hd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h190ch1946h19b4h19b5h19c3h1b0ah1be0h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh19b6n1155h192ch) Date: Thu, 3 Oct 2013 11:13:05 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Michal Simek , , , Dan Williams , Vinod Koul , Dmitry Torokhov , Chris Ball , Alessandro Zummo , Linus Walleij , Mark Brown , Greg Kroah-Hartman , Jiri Slaby , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Wim Van Sebroeck , Andrew Morton , "zhangwei(Jovi)" , Randy Dunlap , , , , , , , , Subject: Re: [PATCH] amba: Ensure drvdata is NULL References: <1b2479137287fa8dfda3089ca0cb9fba8c4b1f1d.1380524337.git.michal.simek@xilinx.com> <20131002202521.GU12758@n2100.arm.linux.org.uk> In-Reply-To: <20131002202521.GU12758@n2100.arm.linux.org.uk> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW Message-ID: X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 31 On 10/02/2013 10:25 PM, Russell King - ARM Linux wrote: > On Mon, Sep 30, 2013 at 08:59:06AM +0200, Michal Simek wrote: >> This patch is inpired by the patch for drvdata >> "device-core: Ensure drvdata = NULL when no driver is bound" >> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d) >> >> Also it fixes all occurences in drivers. >> >> Signed-off-by: Michal Simek >> --- >> This patch has been sent as RFC in this thread. >> http://lkml.org/lkml/2013/9/4/393 > > Why not have the driver core do this? Then it gets applied to all bus > types uniformly. ok - I have checked that path and it should be already done in really_probe function which calls amba_probe() and then driver probe function. It means that the patch should contain just "amba_set_drvdata(dev, NULL);" removal and not touching bus.c file. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/