Message-ID: <524D5B6E.9020605@redhat.com>
Date: Thu, 03 Oct 2013 13:56:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9
MIME-Version: 1.0
To: Gleb Natapov <gleb@redhat.com>
CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/7] KVM: mmu: remove uninteresting MMU "new_cr3" callbacks
References: <1380725776-14948-1-git-send-email-pbonzini@redhat.com> <1380725776-14948-3-git-send-email-pbonzini@redhat.com> <20131003102305.GC17294@redhat.com>
In-Reply-To: <20131003102305.GC17294@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1089
Lines: 22

Il 03/10/2013 12:23, Gleb Natapov ha scritto:
>> > The commit message mentioned that "mmu_free_roots() is somewhat of an overkill,
>> > but fixing that is more complicated and will be done after this minimal fix".
>> > One year has passed, and no one really felt the need to do a different fix.
>> > Wrap the call with a kvm_mmu_new_cr3 function for clarity, but remove the
>> > callback.
>> > 
> Well the reason for it is because whoever knew about the problem found
> other things to do meanwhile :) But do we really need something smarter
> here anyway? The situation described in e676505 should be extremely rare
> even on non unrestricted guest HW and it happens during slow emulation
> anyway, so optimization will likely not be noticeable.

Yeah, and it's not like code that runs without paging will move to cr3
in a hot loop. :)

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/