Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572Ab3JCOCS (ORCPT ); Thu, 3 Oct 2013 10:02:18 -0400 Received: from mx2.parallels.com ([199.115.105.18]:54033 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158Ab3JCOCR convert rfc822-to-8bit (ORCPT ); Thu, 3 Oct 2013 10:02:17 -0400 From: James Bottomley To: KY Srinivasan CC: Geert Uytterhoeven , Mike Christie , Jack Wang , Greg KH , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "ohering@suse.com" , "hch@infradead.org" , "linux-scsi@vger.kernel.org" Subject: Re: Drivers: scsi: FLUSH timeout Thread-Topic: Drivers: scsi: FLUSH timeout Thread-Index: AQHOtkBtWGcmfS/7wkmW+8Ppp9OK8pnPmBJggAU49YCAAAdE0IAAT/uAgABKyICAALYxAIALo8YggAG+A4A= Date: Thu, 3 Oct 2013 14:01:45 +0000 Message-ID: <1380808905.2109.7.camel@dabdike.int.hansenpartnership.com> References: <1379705547-15028-1-git-send-email-kys@microsoft.com> <20130920203222.GA14306@kroah.com> <524180B7.7090307@gmail.com> <3413dbd7fa254fd380a84fe6d9cd87e1@SN2PR03MB061.namprd03.prod.outlook.com> <5241C9E7.2000404@cs.wisc.edu> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.17.213.192] Content-Type: text/plain; charset=US-ASCII Content-ID: Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 41 On Wed, 2013-10-02 at 18:29 +0000, KY Srinivasan wrote: > > > -----Original Message----- > > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > > On Behalf Of Geert Uytterhoeven > > Sent: Wednesday, September 25, 2013 1:40 AM > > To: KY Srinivasan > > Cc: Mike Christie; Jack Wang; Greg KH; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; ohering@suse.com; jbottomley@parallels.com; > > hch@infradead.org; linux-scsi@vger.kernel.org > > Subject: Re: Drivers: scsi: FLUSH timeout > > > > On Tue, Sep 24, 2013 at 11:53 PM, KY Srinivasan wrote: > > > I am not sure how that magic number was arrived at (the 60HZ number). We > > want this to be little higher - > > > > "60 * HZ" means "60 seconds". > > > > > would there be any issues raising this to say 180 seconds. This is the value we > > currently have for I/O > > > timeout. > > > > So you want to replace it by "180 * HZ", which is ... another magic number? > > Ideally, I want this to be adjustable like the way we can change the I/O timeout. > Since that has been attempted earlier and rejected (not clear what the reasons were), > I was suggesting that we pick a larger number. James, let me know how I should proceed here. It's only one problem device with its own driver, right? how about a per target value you set in target_configure? That way there's no damage to the rest of the system even in a mixed device environment. I don't see a particular need to expose this via sysfs unless someone else has a use case. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/