Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715Ab3JCRV7 (ORCPT ); Thu, 3 Oct 2013 13:21:59 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:36560 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991Ab3JCRV5 (ORCPT ); Thu, 3 Oct 2013 13:21:57 -0400 Date: Thu, 3 Oct 2013 13:21:42 -0400 From: Neil Horman To: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org, Joerg Roedel , Bjorn Helgaas , Andy Lutomirski , Konrad Rzeszutek Wilk , Sebastian Andrzej Siewior Subject: Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning Message-ID: <20131003172142.GA20660@hmsreliant.think-freely.org> References: <1380300815-1864-1-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380300815-1864-1-git-send-email-nhorman@tuxdriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2403 Lines: 56 On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote: > The warning for the irq remapping broken check in intel_irq_remapping.c is > pretty pointless. We need the warning, but we know where its comming from, the > stack trace will always be the same, and it needlessly triggers things like > Abrt. This changes the warning to just print a text warning about BIOS being > broken, without the stack trace, then sets the appropriate taint bit. Since we > automatically disable irq remapping, theres no need to contiue making Abrt jump > at this problem > > Signed-off-by: Neil Horman > CC: Joerg Roedel > CC: Bjorn Helgaas > CC: Andy Lutomirski > CC: Konrad Rzeszutek Wilk > CC: Sebastian Andrzej Siewior > --- > drivers/iommu/intel_irq_remapping.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index f71673d..b97d70b 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -525,12 +525,13 @@ static int __init intel_irq_remapping_supported(void) > if (disable_irq_remap) > return 0; > if (irq_remap_broken) { > - WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND, > - "This system BIOS has enabled interrupt remapping\n" > - "on a chipset that contains an erratum making that\n" > - "feature unstable. To maintain system stability\n" > - "interrupt remapping is being disabled. Please\n" > - "contact your BIOS vendor for an update\n"); > + printk(KERN_WARNING > + "This system BIOS has enabled interrupt remapping\n" > + "on a chipset that contains an erratum making that\n" > + "feature unstable. To maintain system stability\n" > + "interrupt remapping is being disabled. Please\n" > + "contact your BIOS vendor for an update\n"); > + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK); > disable_irq_remap = 1; > return 0; > } > -- > 1.8.3.1 > > Ping Bjorn, Jeorg, any thoughts here? Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/