Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290Ab3JCUKS (ORCPT ); Thu, 3 Oct 2013 16:10:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329Ab3JCUKQ (ORCPT ); Thu, 3 Oct 2013 16:10:16 -0400 Date: Thu, 3 Oct 2013 22:12:05 +0200 From: Alexander Gordeev To: "Williams, Dan J" Cc: linux-kernel@vger.kernel.org, Jon Mason , Dave Jiang Subject: Re: [PATCH RFC 34/77] ioat: Update MSI/MSI-X interrupts enablement code Message-ID: <20131003201204.GA28050@dhcp-26-207.brq.redhat.com> References: <63caad476ca6b7f3481d5512febcb4ef3db72209.1380703263.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 20 On Wed, Oct 02, 2013 at 11:00:51AM -0700, Williams, Dan J wrote: > I see patch 00/77 now and I still don't see the need for ioatdma to be > updated. If we fail the subsequent request_irq, the driver will still > fall back to trying less interrupts. In the proposed design pci_enable_msix() will never return a positive value. Therefore if the driver is not updated it will fallback to single MSI if device->common.chancnt MSI-X vectors were not allocated while it used to fallback to a single MSI-X in the same situation. Not to mention 'if (err > 0)' dead code. -- Regards, Alexander Gordeev agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/