Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755411Ab3JCVH1 (ORCPT ); Thu, 3 Oct 2013 17:07:27 -0400 Received: from arkanian.console-pimps.org ([212.110.184.194]:55445 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755244Ab3JCVHZ (ORCPT ); Thu, 3 Oct 2013 17:07:25 -0400 Date: Thu, 3 Oct 2013 22:07:15 +0100 From: Matt Fleming To: Roy Franz Cc: Mark Salter , Linux Kernel Mailing List , linux-efi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , matt.fleming@intel.com, Russell King - ARM Linux , Leif Lindholm , Grant Likely , Dave Martin Subject: Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64 Message-ID: <20131003210715.GD2781@console-pimps.org> References: <1380385403-31904-1-git-send-email-roy.franz@linaro.org> <1380385403-31904-3-git-send-email-roy.franz@linaro.org> <20131003095224.GX21381@console-pimps.org> <1380807804.17503.9.camel@deneb.redhat.com> <20131003142721.GB2781@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 20 On Thu, 03 Oct, at 12:28:03PM, Roy Franz wrote: > Hi Matt, > > This function is shared between ARM and ARM64, which are separate > architectures so to keep this in arch code would require it to be > duplicated for ARM/ARM64. Would moving this function to a new > "efi-stub-fdt.c" file be satisfactory? This file would just be used > the ARM and ARM64, so this would remove > the need for the top-level #ifdefs. Fair enough, move it to drivers/firmware/efi/fdt.c - there's no need to prefix it with "efi-" (efi-pstore.c has historic baggage). -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/