Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442Ab3JCXBK (ORCPT ); Thu, 3 Oct 2013 19:01:10 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:43588 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121Ab3JCXBI (ORCPT ); Thu, 3 Oct 2013 19:01:08 -0400 From: Taras Kondratiuk To: Samuel Ortiz , Lee Jones Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-networking@linaro.org, Kim Phillips , Danke Xie , Taras Kondratiuk Subject: [PATCH v2] mfd: twl6030: Fix endianness problem in IRQ handler Date: Fri, 4 Oct 2013 02:00:34 +0300 Message-Id: <1380841234-19475-1-git-send-email-taras.kondratiuk@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1380712124-20666-1-git-send-email-taras.kondratiuk@linaro.org> References: <1380712124-20666-1-git-send-email-taras.kondratiuk@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 49 From: Danke Xie The current TWL 6030 IRQ handler assumes little endianness. This change makes it endian-neutral. Signed-off-by: Danke Xie Signed-off-by: Taras Kondratiuk --- v2: fixed sparse warning v1: https://patchwork.kernel.org/patch/2974331/ drivers/mfd/twl6030-irq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index 517eda8..18a607e 100644 --- a/drivers/mfd/twl6030-irq.c +++ b/drivers/mfd/twl6030-irq.c @@ -176,8 +176,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data) int i, ret; union { u8 bytes[4]; - u32 int_sts; + __le32 int_sts; } sts; + u32 int_sts; /* sts.int_sts converted to CPU endianness */ struct twl6030_irq *pdata = data; /* read INT_STS_A, B and C in one shot using a burst read */ @@ -196,8 +197,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data) if (sts.bytes[2] & 0x10) sts.bytes[2] |= 0x08; - for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++) - if (sts.int_sts & 0x1) { + int_sts = le32_to_cpu(sts.int_sts); + for (i = 0; int_sts; int_sts >>= 1, i++) + if (int_sts & 0x1) { int module_irq = irq_find_mapping(pdata->irq_domain, pdata->irq_mapping_tbl[i]); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/