Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569Ab3JCXfn (ORCPT ); Thu, 3 Oct 2013 19:35:43 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:32843 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374Ab3JCXfl (ORCPT ); Thu, 3 Oct 2013 19:35:41 -0400 MIME-Version: 1.0 In-Reply-To: <20131003220628.GA14835@google.com> References: <1380399187-4962-1-git-send-email-yinghai@kernel.org> <20131003220628.GA14835@google.com> Date: Thu, 3 Oct 2013 16:35:40 -0700 X-Google-Sender-Auth: 8FYEry4PJz1lrR5YZRW_cUoq_Ow Message-ID: Subject: Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers From: Yinghai Lu To: Bjorn Helgaas Cc: Linus Torvalds , Benjamin Herrenschmidt , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 24 On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas wrote: > On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: >> @@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct pci >> >> pci_enable_bridge(dev->bus->self); >> >> - if (pci_is_enabled(dev)) >> + if (pci_is_enabled(dev)) { >> + if (!dev->is_busmaster) { >> + dev_warn(&dev->dev, "driver skip pci_set_master, fix it!\n"); > > I know this is already in Linus' tree, but if we're going to enable > bus mastering here, what's the point of the warning? If somebody > fixes the driver by adding a pci_set_master() call there, does that > improve something? Help us to catch other offender and fix them. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/