Message-ID: <524E5C8B.7090807@lougher.demon.co.uk>
Date: Fri, 04 Oct 2013 07:13:31 +0100
From: Phillip Lougher <phillip@lougher.demon.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7
MIME-Version: 1.0
To: minchan@kernel.org, linux-kernel@vger.kernel.org
CC: linux-kernel@vger.kernel.org, ch0.han@lge.com, gunho.lee@lge.com
Subject: re: [RFC,3/5] squashfs: remove cache for normal data page
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 6999
Lines: 221

Minchan Kim <minchan@kernel.org> wrote:
>Sqsuashfs have used cache for normal data pages but it's pointless
>because MM already has cache layer and squashfs adds extra pages
>into MM's page cache when it reads a page from compressed block.
>
>This patch removes cache usage for normal data pages so it could
>remove unnecessary one copy

1. As I mentioned last week, the use of the "unnecessary" cache is there
to prevent two or more processes simultaneously trying to read the same
pages.  Without this, such racing processes will decompress the same
blocks repeatedly.

It is easy to dismiss this as an rare event, but, when it happens it
has a major impact on performance, because the racing processes
can get stuck in a lock-step arrangement, repeatedly trying to access
the same blocks until the eof.  If the file is many megabytes or
gigabytes in size (such as when Squashfs is used as a container fs for
cetain liveCDs, or virtual machine disk images) this will lead to
a significant reduction in performance.

So I consider this a major regression.

2. You patch also adds another regression, which is to reintroduce
kmap() rather than kmap_atomic().

I was asked to remove this at my first submission attempt
in 2005

http://lkml.indiana.edu/hypermail/linux/kernel/0503.2/0809.html

So I'm not particularly willing to reintroduce it now.

3. Your patch potentially reintroduces this bug

http://www.spinics.net/lists/linux-fsdevel/msg02555.html
http://zaitcev.livejournal.com/86954.html

4. You patch is unconditional.  With such code changes as this
it is always essential to make this a "buy in option", with the
original behaviour retained as default.  Otherwise, lots of users
potentially find their embedded/enterprise/mission critical
system unexpectedly breaks when upgrading the kernel, and I get
a lot of angry email.

Phillip


>(ie, from cache to page cache) and
>decouple normal data page path from squashfs cache layer.
>
>Signed-off-by: Minchan Kim <minchan@kernel.org>
>
>---
>fs/squashfs/file.c |  117 +++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 75 insertions(+), 42 deletions(-)
>
>diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c
>index d4d472f..36508c3 100644
>--- a/fs/squashfs/file.c
>+++ b/fs/squashfs/file.c
>@@ -505,11 +505,14 @@ skip_page:
> static int squashfs_regular_readpage(struct file *file, struct page *page)
> {
> 	u64 block = 0;
>-	int bsize;
>-	struct inode *inode = page->mapping->host;
>+	int bsize, i, data_len, pages, nr_pages = 0;
>+	struct address_space *mapping = page->mapping;
>+	struct inode *inode = mapping->host;
> 	struct squashfs_sb_info *msblk = inode->i_sb->s_fs_info;
>-	int bytes, i, offset = 0;
>-	struct squashfs_cache_entry *buffer = NULL;
>+	gfp_t gfp_mask;
>+	struct page *push_page;
>+	struct page **page_array;
>+	void **buffer = NULL;
> 	void *pageaddr;
>
> 	int mask = (1 << (msblk->block_log - PAGE_CACHE_SHIFT)) - 1;
>@@ -519,6 +522,8 @@ static int squashfs_regular_readpage(struct file *file, struct page *page)
> 	TRACE("Entered squashfs_readpage, page index %lx, start block %llx\n",
> 				page->index, squashfs_i(inode)->start);
>
>+	pages = msblk->block_size >> PAGE_CACHE_SHIFT;
>+	pages = pages ? pages : 1;
> 	/*
> 	 * Reading a datablock from disk.  Need to read block list
> 	 * to get location and block size.
>@@ -527,60 +532,88 @@ static int squashfs_regular_readpage(struct file *file, struct page *page)
> 	if (bsize < 0)
> 		goto error_out;
>
>-	if (bsize == 0) { /* hole */
>+	if (bsize == 0)
> 		return squashfs_hole_readpage(file, inode, index, page);
>-	} else {
>-		/*
>-		 * Read and decompress datablock.
>-		 */
>-		buffer = squashfs_get_datablock(inode->i_sb,
>-							block, bsize);
>-		if (buffer->error) {
>-			ERROR("Unable to read page, block %llx, size %x\n",
>-				block, bsize);
>-			squashfs_cache_put(buffer);
>-			goto error_out;
>-		}
>-		bytes = buffer->length;
>-	}
>+
> 	/*
>-	 * Loop copying datablock into pages.  As the datablock likely covers
>-	 * many PAGE_CACHE_SIZE pages (default block size is 128 KiB) explicitly
>-	 * grab the pages from the page cache, except for the page that we've
>-	 * been called to fill.
>+	 * Read and decompress data block
> 	 */
>-	for (i = start_index; bytes > 0; i++,
>-			bytes -= PAGE_CACHE_SIZE, offset += PAGE_CACHE_SIZE) {
>-		struct page *push_page;
>-		int avail = min_t(int, bytes, PAGE_CACHE_SIZE);
>+	gfp_mask = mapping_gfp_mask(mapping);
>+	buffer = kcalloc(1 << (msblk->block_log - PAGE_CACHE_SHIFT),
>+				sizeof(void *), GFP_KERNEL);
>+	if (!buffer)
>+		return -ENOMEM;
>
>-		TRACE("bytes %d, i %d, available_bytes %d\n", bytes, i, avail);
>+	page_array = kcalloc(1 << (msblk->block_log - PAGE_CACHE_SHIFT),
>+				sizeof(struct page *), GFP_KERNEL);
>
>-		push_page = (i == page->index) ? page :
>-			grab_cache_page_nowait(page->mapping, i);
>+	if (!page_array)
>+		goto release_buffer;
>
>+	/* alloc buffer pages */
>+	for (i = 0; i < pages; i++) {
>+		if (page->index == start_index + i)
>+			push_page = page;
>+		else
>+			push_page = __page_cache_alloc(gfp_mask);
> 		if (!push_page)
>-			continue;
>+			goto release_page_array;
>+		nr_pages++;
>+		buffer[i] = kmap(push_page);
>+		page_array[i] = push_page;
>+	}
>
>-		if (PageUptodate(push_page))
>-			goto skip_page;
>+	data_len = squashfs_read_datablock(inode->i_sb, buffer,
>+			block, bsize, msblk->block_size, pages);
>
>-		pageaddr = kmap_atomic(push_page);
>-		squashfs_copy_data(pageaddr, buffer, offset, avail);
>-		memset(pageaddr + avail, 0, PAGE_CACHE_SIZE - avail);
>-		kunmap_atomic(pageaddr);
>+	if (data_len < 0) {
>+		ERROR("Unable to read page, block %llx, size %x\n",
>+			block, bsize);
>+		for (i = 0; i < nr_pages; i++) {
>+			kunmap(page_array[i]);
>+			page_cache_release(page_array[i]);
>+		}
>+		kfree(buffer);
>+		kfree(page_array);
>+		goto error_out;
>+	}
>+
>+	for (i = 0; i < pages; i++) {
>+		push_page = page_array[i];
> 		flush_dcache_page(push_page);
> 		SetPageUptodate(push_page);
>-skip_page:
>-		unlock_page(push_page);
>-		if (i != page->index)
>+		kunmap(page_array[i]);
>+		if (page->index == start_index + i) {
>+			unlock_page(push_page);
>+			continue;
>+		}
>+
>+		if (add_to_page_cache_lru(push_page, mapping,
>+			start_index + i, gfp_mask)) {
> 			page_cache_release(push_page);
>-	}
>+			continue;
>+		}
>
>-	squashfs_cache_put(buffer);
>+		unlock_page(push_page);
>+		page_cache_release(push_page);
>+	}
>
>+	kfree(page_array);
>+	kfree(buffer);
> 	return 0;
>
>+release_page_array:
>+	for (i = 0; i < nr_pages; i++) {
>+		kunmap(page_array[i]);
>+		page_cache_release(page_array[i]);
>+	}
>+
>+	kfree(page_array);
>+
>+release_buffer:
>+	kfree(buffer);
>+	return -ENOMEM;
>+
> error_out:
> 	SetPageError(page);
> 	pageaddr = kmap_atomic(page);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/