From: Peter =?iso-8859-1?q?H=FCwe?= <PeterHuewe@gmx.de>
To: tpmdd-devel@lists.sourceforge.net, Ashley Lai <ashley@ashleylai.com>
Subject: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c)
Date: Fri, 4 Oct 2013 17:50:01 +0200
User-Agent: KMail/1.13.7 (Linux/3.10.9; KDE/4.10.5; x86_64; ; )
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, Rajiv Andrade <mail@srajiv.net>,
        Sirrix AG <tpmdd@sirrix.com>
References: <1379960083-8942-1-git-send-email-jgunthorpe@obsidianresearch.com> <201310020114.18624.PeterHuewe@gmx.de> <20131003050504.GA2247@obsidianresearch.com>
In-Reply-To: <20131003050504.GA2247@obsidianresearch.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201310041750.01145.PeterHuewe@gmx.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1240
Lines: 35

Am Donnerstag, 3. Oktober 2013, 07:05:04 schrieb Jason Gunthorpe:
> On Wed, Oct 02, 2013 at 01:14:18AM +0200, Peter H?we wrote:
> > > I botched the makefile changes for the new .c files.
> > > 
> > > I believe it should be like this:
> > > 
> > > obj-$(CONFIG_TCG_TPM) += tpm-core.o
> > > tpm-core-y := tpm.o tpm-dev.o tpm-sysfs.o
> > > 
> 
> It looks like my solution changes the tpm module name to tpm-core.o.
> This should be noted in the commit log:
> 
>  In doing so we also change the core tpm module name from 'tpm' to
> 'tpm-core', this is because kbuild does not like it if a multi-file module
> has a .c file of the same name.
> 
> Is that OK? It follows the pattern other systems have in the kernel.


Hmm,
I'm not 100% sure what's the usual procedure for module renames, especially 
since this is visible in userspace.

For users the easiest way would be to rename tpm.c to tpm-core.c and leave the 
module name as it is.
In git that's just a simple rename operation.

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/