Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793Ab3JDQpt (ORCPT ); Fri, 4 Oct 2013 12:45:49 -0400 Received: from mail-qe0-f54.google.com ([209.85.128.54]:57714 "EHLO mail-qe0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab3JDQps (ORCPT ); Fri, 4 Oct 2013 12:45:48 -0400 Date: Fri, 4 Oct 2013 11:45:43 -0500 (CDT) From: Ashley Lai To: Jason Gunthorpe cc: Peter H?we , tpmdd-devel@lists.sourceforge.net, Ashley Lai , Leonidas Da Silva Barbosa , linux-kernel@vger.kernel.org, Rajiv Andrade , Sirrix AG Subject: Re: TPM.ko module rename (was tpm: Pull everything related to /dev/tpmX into tpm-dev.c) In-Reply-To: <20131004162808.GA10315@obsidianresearch.com> Message-ID: References: <1379960083-8942-1-git-send-email-jgunthorpe@obsidianresearch.com> <201310020114.18624.PeterHuewe@gmx.de> <20131003050504.GA2247@obsidianresearch.com> <201310041750.01145.PeterHuewe@gmx.de> <20131004162808.GA10315@obsidianresearch.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 34 On Fri, 4 Oct 2013, Jason Gunthorpe wrote: > On Fri, Oct 04, 2013 at 05:50:01PM +0200, Peter H?we wrote: > >> I'm not 100% sure what's the usual procedure for module renames, especially >> since this is visible in userspace. >> >> For users the easiest way would be to rename tpm.c to tpm-core.c and >> leave the module name as it is. In git that's just a simple rename >> operation. > > I agree, keeping the old name seems much safer. > > I'm thinking of following the pattern seen in RTC. Rename tpm.c to > tpm-interface.c and eventually migrate all the driver model support > items into tpm-class.c. > > Does that seem good? I'll respin the patches and test modular rebuilds. > > Jason > Me too, I vote to keep the same module name. Please let me know when you are done with this patch, I would like to test it out. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/