Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402Ab3JDRj2 (ORCPT ); Fri, 4 Oct 2013 13:39:28 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:38576 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755376Ab3JDRj0 (ORCPT ); Fri, 4 Oct 2013 13:39:26 -0400 Date: Fri, 4 Oct 2013 19:39:22 +0200 From: Ingo Molnar To: Roy Franz Cc: "H. Peter Anvin" , Matt Fleming , linux-efi@vger.kernel.org, patches@linaro.org, msalter@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove redundant and incorrect memset() Message-ID: <20131004173922.GA15959@gmail.com> References: <20131003131054.GB27835@gmail.com> <1380902566-30867-1-git-send-email-roy.franz@linaro.org> <20131004173310.GA15689@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 50 * Roy Franz wrote: > On Oct 4, 2013 1:33 PM, "Ingo Molnar" wrote: > > > > > > * Roy Franz wrote: > > > > > Remove a redundant memset() call from efi_relocate_kernel() that > > > was clearing memory that would be used by BSS in non-compressed > > > images loaded with this function. This clear was redundant with > > > the clearing done in the image itself, and also implemented incorrectly > > > with a 0 length. > > > > > > Signed-off-by: Roy Franz > > > Acked-by: Mark Salter > > > > Note the title: > > > > [PATCH] Remove redundant and incorrect memset() > > > > if it's both redundant *and* incorrect then the other memset() must be > > incorrect too and must be removed as well ;-) > > > > I suspect you wanted the title to say: > > > > [PATCH] Remove redundant memset() > > > > ? > > > > Thanks, > > > > Ingo > Hi Ingo, > > The memset being removed is redundant with a correctly implemented > memset in the kernel itself. The memset being removed is also incorrect, > with a hard coded length of 0. So it was redundantly clearing nothing? ;-) Anyway, I agree, the title makes sense. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/