Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384Ab3JDX4A (ORCPT ); Fri, 4 Oct 2013 19:56:00 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:39374 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345Ab3JDXz6 (ORCPT ); Fri, 4 Oct 2013 19:55:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <20131004011806.GE20450@dangermouse.emea.sgi.com> Date: Fri, 4 Oct 2013 16:55:56 -0700 X-Google-Sender-Auth: bB_9QCasGxFa9zT-MTG8ypE3FnI Message-ID: Subject: Re: Commit 07f9b61 breaks systems that don't implement a _CBA method From: Yinghai Lu To: Bjorn Helgaas Cc: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ethan Zhao Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 16 On Fri, Oct 4, 2013 at 3:11 PM, Bjorn Helgaas wrote: > On Thu, Oct 3, 2013 at 7:18 PM, Hedi Berriche wrote: > It's regrettable that the code is so subtle. The obvious thing to do > would be to check for _CBA, and if it doesn't exist, look for an MCFG > entry. But for various historical reasons, the code is a mess, and we > haven't figured out how to safely simplify it. > > Ethan, Yinghai, any objections to reverting 07f9b61? yes, that is right solution. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/