Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817Ab3JEAw6 (ORCPT ); Fri, 4 Oct 2013 20:52:58 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:59838 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751307Ab3JEAw5 (ORCPT ); Fri, 4 Oct 2013 20:52:57 -0400 Date: Fri, 4 Oct 2013 20:52:53 -0400 From: Steven Rostedt To: Andi Kleen Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, Andi Kleen Subject: Re: [PATCH 4/6] trace: Make UPROBES depend on PERF_EVENTS Message-ID: <20131004205253.64dc04c9@gandalf.local.home> In-Reply-To: <1380922788-23112-5-git-send-email-andi@firstfloor.org> References: <1380922788-23112-1-git-send-email-andi@firstfloor.org> <1380922788-23112-5-git-send-email-andi@firstfloor.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 38 On Fri, 4 Oct 2013 14:39:46 -0700 Andi Kleen wrote: > From: Andi Kleen > > UPROBES need the perf events code, so add a dependency > from PERF_EVENTS to UPROBES. Can you please be a bit more specific on what uprobes requires of perf? That is, what part of the perf events code is needed, and why? -- Steve > > Cc: rostedt@goodmis.org > Signed-off-by: Andi Kleen > --- > kernel/trace/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 015f85a..8639819 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -424,6 +424,7 @@ config UPROBE_EVENT > bool "Enable uprobes-based dynamic events" > depends on ARCH_SUPPORTS_UPROBES > depends on MMU > + depends on PERF_EVENTS > select UPROBES > select PROBE_EVENTS > select TRACING -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/