Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513Ab3JEPv7 (ORCPT ); Sat, 5 Oct 2013 11:51:59 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57115 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445Ab3JEPv5 (ORCPT ); Sat, 5 Oct 2013 11:51:57 -0400 Date: Sat, 5 Oct 2013 08:51:48 -0700 From: Christoph Hellwig To: "Theodore Ts'o" , "Dilger, Andreas" , Greg KH , Peng Tao , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: lustre: why does cfs_get_random_bytes() exist? Message-ID: <20131005155148.GA20741@infradead.org> References: <20131003234545.GA19796@thunk.org> <20131005142121.GA22773@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131005142121.GA22773@thunk.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 22 On Sat, Oct 05, 2013 at 10:21:21AM -0400, Theodore Ts'o wrote: > add_device_randomness() is called from __dev_open() and > dev_set_mac_address() in net/core/dev.c. This is above the ethernet > and infiniband level. So as long as it looks like a Linux network > device, and they are setting the hardware media access address in the > standard place (dev->dev_addr), it should work fine. > > If they don't then they should fix their drivers to call > add_device_randomness(); the answer shouldn't be to make every single > users of the Linux random number generation infrastructure work around > the problem at the subsystem or file system level! Besides these points a filesystem isn't the place to work around entropy pool issues on some obscure platform. Even if they can't fix it this way for some reason the workaround still should be in the interaction of the arch code and the Linux prng infrastructure and not in Lustre. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/