Message-ID: <1380996319.2081.126.camel@joe-AO722>
Subject: Re: [PATCH 2/5] drivers: usb: core: hcd: Whitespace fixes
From: Joe Perches <joe@perches.com>
To: Matthias Beyer <mail@beyermatthias.de>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Sat, 05 Oct 2013 11:05:19 -0700
In-Reply-To: <1380996244.2081.125.camel@joe-AO722>
References: <cover.1380986962.git.mail@beyermatthias.de>
	 <e5dba9e89cd8c98d7d2f2578b72482ccf0a4ea88.1380986962.git.mail@beyermatthias.de>
	 <1380996244.2081.125.camel@joe-AO722>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 26

On Sat, 2013-10-05 at 11:04 -0700, Joe Perches wrote:
> On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
> > - removing spaces before array indexing (foo [] to foo[])
> []
> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> []
> > @@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
> >  /* used when allocating bus numbers */
> >  #define USB_MAXBUS		64
> >  struct usb_busmap {
> > -	unsigned long busmap [USB_MAXBUS / (8*sizeof (unsigned long))];
> > +	unsigned long busmap[USB_MAXBUS / (8*sizeof (unsigned long))];
> 
> this would be nicer as
> 
> 	DEFINE_BITMAP(busmap, USB_MAXBUS);
> 

nack, DECLARE_BITMAP(...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/