Message-ID: <1380999108.2081.138.camel@joe-AO722>
Subject: Re: [PATCH] checkpatch.pl: Check for the FSF mailing address
From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sat, 05 Oct 2013 11:51:48 -0700
In-Reply-To: <20131005184307.GA6429@leaf>
References: <20131005184307.GA6429@leaf>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1398
Lines: 40

On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> Kernel maintainers reject new instances of the GPL boilerplate paragraph
> directing people to write to the FSF for a copy of the GPL, since the
> FSF has moved in the past and may do so again.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1859,6 +1859,16 @@ sub process {
>  			$rpt_cleaners = 1;
>  		}
>  
> +# Check for FSF mailing addresses.
> +		if ($rawline =~ /You should have received a copy/ ||

There are over 9,000 of these in the tree.

> +		    $rawline =~ /write to the Free Software/ ||

Over 7,000

> +		    $rawline =~ /59 Temple Place/ ||

Over 3,500

> +		    $rawline =~ /51 Franklin Street/) {

Over 1,500

> +			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> +			ERROR("FSF_MAILING_ADDRESS",
> +			      "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)

Is this really a useful ERROR condition?
Maybe a CHK --strict test or a warning instead?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/