Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528Ab3JEUAF (ORCPT ); Sat, 5 Oct 2013 16:00:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38983 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354Ab3JEUAD (ORCPT ); Sat, 5 Oct 2013 16:00:03 -0400 Date: Sat, 5 Oct 2013 21:59:49 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Dave Jones , Linux Kernel , gregkh@linuxfoundation.org, peter@hurleysoftware.com Subject: Re: tty^Wrcu/perf lockdep trace. Message-ID: <20131005195949.GW3081@twins.programming.kicks-ass.net> References: <20131003194226.GO28601@twins.programming.kicks-ass.net> <20131003195832.GU5790@linux.vnet.ibm.com> <20131004065835.GP28601@twins.programming.kicks-ass.net> <20131004160352.GF5790@linux.vnet.ibm.com> <20131004165044.GV28601@twins.programming.kicks-ass.net> <20131004170954.GK5790@linux.vnet.ibm.com> <20131004185239.GS15690@laptop.programming.kicks-ass.net> <20131004212506.GM5790@linux.vnet.ibm.com> <20131005160511.GV3081@twins.programming.kicks-ass.net> <20131005162802.GP5790@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131005162802.GP5790@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2590 Lines: 56 On Sat, Oct 05, 2013 at 09:28:02AM -0700, Paul E. McKenney wrote: > On Sat, Oct 05, 2013 at 06:05:11PM +0200, Peter Zijlstra wrote: > > On Fri, Oct 04, 2013 at 02:25:06PM -0700, Paul E. McKenney wrote: > > > > Why > > > > do we still have a per-cpu kthread in nocb mode? The idea is that we do > > > > not disturb the cpu, right? So I suppose these kthreads get to run on > > > > another cpu. > > > > > > Yep, the idea is that usermode figures out where to run them. Even if > > > usermode doesn't do that, this has the effect of getting them to be > > > more out of the way of real-time tasks. > > > > > > > Since its running on another cpu; we get into atomic and memory barriers > > > > anyway; so why not keep the logic the same as no-nocb but have another > > > > cpu check our nocb cpu's state. > > > > > > You can do that today by setting rcu_nocb_poll, but that results in > > > frequent polling wakeups even when the system is completely idle, which > > > is out of the question for the battery-powered embedded guys. > > > > So its this polling I don't get.. why is the different behaviour > > required? And why would you continue polling if the cpus were actually > > idle. > > The idea is to offload the overhead of doing the wakeup from (say) > a real-time thread/CPU onto some housekeeping CPU. Sure I get that that is the idea; what I don't get is why it needs to behave differently depending on NOCB. Why does a NOCB thingy need to wake up the kthread far more often? > > Is there some confusion between the nr_running==1 extended quiescent > > state and the nr_running==0 extended quiescent state? > > This is independent of the nr_running=1 extended quiescent state. The > wakeups only happen when runnning in the kernel. That said, a real-time > thread might want both rcu_nocb_poll=y and CONFIG_NO_HZ_FULL=y. So there's 3 behaviours? - CONFIG_NO_HZ_FULL=n - CONFIG_NO_HZ_FULL=y, rcu_nocb_poll=n - CONFIG_NO_HZ_FULL=y, rcu_nocb_poll=y What I'm trying to understand is why do all those things behave differently? For all 3 configs there's kthreads that do the GP advancing and can run on different cpus. And why does rcu_nocb_poll=y need to be terrible for power usage; surely we know when cpus are actually idle and can stop polling them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/