Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512Ab3JFFvg (ORCPT ); Sun, 6 Oct 2013 01:51:36 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:53824 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339Ab3JFFvd (ORCPT ); Sun, 6 Oct 2013 01:51:33 -0400 MIME-Version: 1.0 In-Reply-To: <1380301041-26405-3-git-send-email-gdjakov@mm-sol.com> References: <1380301041-26405-1-git-send-email-gdjakov@mm-sol.com> <1380301041-26405-3-git-send-email-gdjakov@mm-sol.com> Date: Sat, 5 Oct 2013 22:51:32 -0700 Message-ID: Subject: Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets From: Bjorn Andersson To: Georgi Djakov Cc: linux-mmc@vger.kernel.org, Chris Ball , Grant Likely , Rob Herring , devicetree@vger.kernel.org, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, rob@landley.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Asutosh Das , Venkat Gopalakrishnan , Sahitya Tummala , Subhash Jadavani Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 33 Hi Georgi, Thanks for working on this, unfortunately it seems like I need to port the rpm regulators to be able to test this. But I did find that... On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov wrote: > ... > +static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) > +{ > + struct sdhci_msm_host *msm_host = (struct sdhci_msm_host *)data; > ... > +static int sdhci_msm_probe(struct platform_device *pdev) > +{ > + struct sdhci_host *host; > + struct sdhci_msm_host *msm_host; > ... > + ret = devm_request_threaded_irq(&pdev->dev, msm_host->pwr_irq, NULL, > + sdhci_msm_pwr_irq, IRQF_ONESHOT, > + dev_name(&pdev->dev), host); > ... ...sdhci_msm_pwr_irq() expects the data pointer to be msm_host, not sdhci_host, so right now I only get a panic. So I suspect you mean msm_host as the last param here. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/