Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530Ab3JFGLj (ORCPT ); Sun, 6 Oct 2013 02:11:39 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:33462 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893Ab3JFGLh (ORCPT ); Sun, 6 Oct 2013 02:11:37 -0400 MIME-Version: 1.0 In-Reply-To: <521D2047.8030300@wwwdotorg.org> References: <5217DB0C.7000101@wwwdotorg.org> <20130827170120.GR4035@joshc.qualcomm.com> <521D2047.8030300@wwwdotorg.org> Date: Sat, 5 Oct 2013 23:11:36 -0700 Message-ID: Subject: Re: [PATCH RFC v2 3/5] spmi: add generic SPMI controller binding documentation From: Bjorn Andersson To: Stephen Warren Cc: Josh Cartwright , Grant Likely , Rob Herring , Greg Kroah-Hartman , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Sagar Dharia , Gilad Avidov , Michael Bohan , devicetree@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 35 On Tue, Aug 27, 2013 at 2:55 PM, Stephen Warren wrote: > On 08/27/2013 11:01 AM, Josh Cartwright wrote: > ... > cell 0 - address type (0: master, 1: unique ID, 2: group ID, ...) I think it would make sense to have the master id as a property of the bus, as you could consider this to indicate different buses and then usid, gsid and base being part of the reg. > cell 1 - address value I did hack up Josh patchset to read a reg touple of instead of just usid. I stored the second value in the spmi_device struct for easy access, but maybe it should be done like on codeaurora; in a resource? I believe this looks nice, but as I haven't read the mipi spec I wonder, will there be a case where you don't have an offset/base? Should it just be made optional? Can we make the address and have the code populate a resource based on a reg-names property? That way it would be possible to extend it to support gsid in case we want to (would require reg-names though). With the hack to Josh's patchset I quickly ported qpnp-revision and qpnp-vibrator, and it seems to work quite nicely. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/