Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755953Ab3JGPND (ORCPT ); Mon, 7 Oct 2013 11:13:03 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:47616 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755904Ab3JGPM5 (ORCPT ); Mon, 7 Oct 2013 11:12:57 -0400 Date: Mon, 7 Oct 2013 16:12:13 +0100 From: Mark Rutland To: Jonas Jensen Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "vinod.koul@intel.com" , "djbw@fb.com" , "arnd@arndb.de" , "linux@arm.linux.org.uk" , devicetree@vger.kernel.org Subject: Re: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver Message-ID: <20131007151212.GF15365@e106331-lin.cambridge.arm.com> References: <1381151633-8576-1-git-send-email-jonas.jensen@gmail.com> <1381155034-11254-1-git-send-email-jonas.jensen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381155034-11254-1-git-send-email-jonas.jensen@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2866 Lines: 79 [adding devicetree] On Mon, Oct 07, 2013 at 03:10:34PM +0100, Jonas Jensen wrote: > The MOXA ART SoC has a DMA controller capable of offloading expensive > memory operations, such as large copies. This patch adds support for > the controller including four channels. Two of these are used to > handle MMC copy on the UC-7112-LX hardware. The remaining two can be > used in a future audio driver or client application. > > Signed-off-by: Jonas Jensen > --- > > Notes: > Changes since v9: > > 1. reorder probe path, also move dma_async_device_register() to happen after devm_request_irq() > > Applies to next-20130927 > > .../devicetree/bindings/dma/moxa,moxart-dma.txt | 19 + > drivers/dma/Kconfig | 7 + > drivers/dma/Makefile | 1 + > drivers/dma/moxart-dma.c | 651 +++++++++++++++++++++ > 4 files changed, 678 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt > create mode 100644 drivers/dma/moxart-dma.c > > diff --git a/Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt b/Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt > new file mode 100644 > index 0000000..79facce > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/moxa,moxart-dma.txt > @@ -0,0 +1,19 @@ > +MOXA ART DMA Controller > + > +See dma.txt first > + > +Required properties: > + > +- compatible : Must be "moxa,moxart-dma" Sorry I didn't notice this previously, but "moxa" isn't in Documentation/devicetree/bindings/vendor-prefixes.txt (despite several bindings using it). Could you cook up a separate patch to add an entry for Moxa, please? Also, given the SoC is called "ART" it's a shame that we're calling this "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent for "moxart" in bindings though, so changing that's likely to lead to more problems. > +- reg : Should contain registers location and length > +- interrupts : Should contain the interrupt number Sorry for yet more pendantry, but could we instead have: - interrupts: Should contain an interrupt-specifier for the sole interrupt generated by the device. > +- #dma-cells : Should be 1, a single cell holding a line request number > + > +Example: > + > + dma: dma@90500000 { > + compatible = "moxa,moxart-dma"; > + reg = <0x90500080 0x40>; > + interrupts = <24 0>; > + #dma-cells = <1>; > + }; Otherwise I think the binding looks OK. Thanks, Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/