Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130Ab3JGPwD (ORCPT ); Mon, 7 Oct 2013 11:52:03 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:26914 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754735Ab3JGPv5 (ORCPT ); Mon, 7 Oct 2013 11:51:57 -0400 Date: Mon, 7 Oct 2013 11:51:52 -0400 From: Steven Rostedt To: Hannes Frederic Sowa Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jason Baron , Peter Zijlstra , Eric Dumazet , "andi @ firstfloor. org David S. Miller" , x86@kernel.org Subject: Re: [PATCH] static_key: WARN on usage before jump_label_init was called Message-ID: <20131007115152.0964afde@gandalf.local.home> In-Reply-To: <20131006182919.GD9295@order.stressinduktion.org> References: <1381015258-7667-1-git-send-email-hannes@stressinduktion.org> <1381015258-7667-4-git-send-email-hannes@stressinduktion.org> <20131005200558.3be2f841@gandalf.local.home> <20131006001247.GB25076@order.stressinduktion.org> <20131006182919.GD9295@order.stressinduktion.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 28 On Sun, 6 Oct 2013 20:29:19 +0200 Hannes Frederic Sowa wrote: > diff --git a/lib/jump_label_initialized.c b/lib/jump_label_initialized.c > new file mode 100644 > index 0000000..a668a40 > --- /dev/null > +++ b/lib/jump_label_initialized.c > @@ -0,0 +1,6 @@ > +#include > +#include > + > +bool static_key_initialized __read_mostly = false; > +EXPORT_SYMBOL_GPL(static_key_initialized); > + So far, the only thing I don't like about this patch is the creation of this file for the sole purpose of adding this variable. Perhaps it can just be added to init/main.c? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/