Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756244Ab3JGRe7 (ORCPT ); Mon, 7 Oct 2013 13:34:59 -0400 Received: from mail-qe0-f50.google.com ([209.85.128.50]:36157 "EHLO mail-qe0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625Ab3JGRez (ORCPT ); Mon, 7 Oct 2013 13:34:55 -0400 MIME-Version: 1.0 In-Reply-To: <20131007.125326.895480090584703586.davem@davemloft.net> References: <1380880333-3546-1-git-send-email-ou.ghorbel@gmail.com> <20131007.125326.895480090584703586.davem@davemloft.net> Date: Mon, 7 Oct 2013 18:34:53 +0100 Message-ID: Subject: Re: [PATCH] Fix the upper MTU limit in ipv6 GRE tunnel From: Oussama Ghorbel To: David Miller Cc: Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 34 OK, I've resubmitted the patch with the proper Subject line. The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel Thanks, Oussama On Mon, Oct 7, 2013 at 5:53 PM, David Miller wrote: > From: Oussama Ghorbel > Date: Fri, 4 Oct 2013 10:52:13 +0100 > >> Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6 >> headers. This length is also counted in dev->hard_header_len. >> Perhaps, it's more clean to modify the hlen to count only the GRE header >> without ipv6 header as the variable name suggest, but the simple way to fix >> this without regression risk is simply modify the calculation of the limit >> in ip6gre_tunnel_change_mtu function. >> Verified in kernel version v3.11. >> >> Signed-off-by: Oussama Ghorbel > > Please resubmit this with a proper Subject line. > > It should be "[PATCH] " then a legitimate subsystem prefix. > In this case "ipv6: " would be appropriate. And then > the "ipv6" in your existing Subject text is redundant so > can be removed. > > Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/