Message-ID: <1381181602.2081.214.camel@joe-AO722>
Subject: Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict
 check only
From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Josh Triplett <josh@joshtriplett.org>, torvalds@linux-foundation.org,
        gregkh@linux-foundation.org, Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
Date: Mon, 07 Oct 2013 14:33:22 -0700
In-Reply-To: <20131007212302.GB13318@ZenIV.linux.org.uk>
References: <20131007191835.GA28737@jtriplet-mobl1>
	 <1381174106.2081.207.camel@joe-AO722>
	 <20131007193433.GF13643@jtriplet-mobl1>
	 <20131007212302.GB13318@ZenIV.linux.org.uk>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1525
Lines: 46

On Mon, 2013-10-07 at 22:23 +0100, Al Viro wrote:
> On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote:
> 
> > I've seen far more examples of the 80-column limit making code less
> > readable rather than more.  It's only really helpful when it forces code
> > restructuring, *not* when it just forces an arbitrary line break.
> 
> So teach that piece of crap to complain about fucked-in-head line breaks like
> 							ret_val =
> 							    leaf_shift_left(tb,
> 									    tb->
> 									    lnum
> 									    [0],
> 									    tb->
> 									    lbytes
> 									    -
> 									    1);
> in addition to obscenely long lines (and yes, it is a real-world example).

Yup, that's pretty ugly.

It was autogenerated and introduced when Linus
rather arbitrarily lindented the reiserfs code.

btw: I think lindent should be removed from scripts/
http://lkml.org/lkml/2013/2/11/390

I believe reiserfs was originally set to a 132
column width maximum.

commit bd4c625c061c2a38568d0add3478f59172455159
Author: Linus Torvalds <torvalds@g5.osdl.org>
Date:   Tue Jul 12 20:21:28 2005 -0700

    reiserfs: run scripts/Lindent on reiserfs code
    
    This was a pure indentation change, using:
    
        scripts/Lindent fs/reiserfs/*.c include/linux/reiserfs_*.h


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/