Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959Ab3JGW5W (ORCPT ); Mon, 7 Oct 2013 18:57:22 -0400 Received: from terminus.zytor.com ([198.137.202.10]:32822 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197Ab3JGW5T (ORCPT ); Mon, 7 Oct 2013 18:57:19 -0400 Message-ID: <52533C12.9090007@zytor.com> Date: Mon, 07 Oct 2013 15:56:18 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: John Stultz CC: LKML , Minchan Kim , Andrew Morton , Android Kernel Team , Robert Love , Mel Gorman , Hugh Dickins , Dave Hansen , Rik van Riel , Dmitry Adamushko , Dave Chinner , Neil Brown , Andrea Righi , Andrea Arcangeli , "Aneesh Kumar K.V" , Mike Hommey , Taras Glek , Dhaval Giani , Jan Kara , KOSAKI Motohiro , Michel Lespinasse , Rob Clark , "linux-mm@kvack.org" Subject: Re: [PATCH 05/14] vrange: Add new vrange(2) system call References: <1380761503-14509-1-git-send-email-john.stultz@linaro.org> <1380761503-14509-6-git-send-email-john.stultz@linaro.org> In-Reply-To: <1380761503-14509-6-git-send-email-john.stultz@linaro.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2403 Lines: 69 On 10/02/2013 05:51 PM, John Stultz wrote: > From: Minchan Kim > > This patch adds new system call sys_vrange. > > NAME > vrange - Mark or unmark range of memory as volatile > vrange() is about as nondescriptive as one can get -- there is exactly one letter that has any connection with that this does. > SYNOPSIS > int vrange(unsigned_long start, size_t length, int mode, > int *purged); > > DESCRIPTION > Applications can use vrange(2) to advise the kernel how it should > handle paging I/O in this VM area. The idea is to help the kernel > discard pages of vrange instead of reclaiming when memory pressure > happens. It means kernel doesn't discard any pages of vrange if > there is no memory pressure. > > mode: > VRANGE_VOLATILE > hint to kernel so VM can discard in vrange pages when > memory pressure happens. > VRANGE_NONVOLATILE > hint to kernel so VM doesn't discard vrange pages > any more. > > If user try to access purged memory without VRANGE_NOVOLATILE call, > he can encounter SIGBUS if the page was discarded by kernel. > > purged: Pointer to an integer which will return 1 if > mode == VRANGE_NONVOLATILE and any page in the affected range > was purged. If purged returns zero during a mode == > VRANGE_NONVOLATILE call, it means all of the pages in the range > are intact. I'm a bit confused about the "purged" >From an earlier version of the patch: > - What's different with madvise(DONTNEED)? > > System call semantic > > DONTNEED makes sure user always can see zero-fill pages after > he calls madvise while vrange can see data or encounter SIGBUS. This difference doesn't seem to be a huge one. The other one seems to be the blocking status of MADV_DONTNEED, which perhaps may be better handled by adding an option (MADV_LAZY) perhaps? That way we would have lazy vs. immediate, and zero versus SIGBUS. I see from the change history of the patch that this was an madvise() at some point, but was changed into a separate system call at some point, does anyone remember why that was? A quick look through my LKML archives doesn't really make it clear. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/