Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960Ab3JHALQ (ORCPT ); Mon, 7 Oct 2013 20:11:16 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:52800 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591Ab3JHALO (ORCPT ); Mon, 7 Oct 2013 20:11:14 -0400 MIME-Version: 1.0 In-Reply-To: <1381190594.2081.228.camel@joe-AO722> References: <1381189523.2081.225.camel@joe-AO722> <20131007165626.be437f74a4ba39e2be21af55@linux-foundation.org> <1381190594.2081.228.camel@joe-AO722> From: Bjorn Helgaas Date: Mon, 7 Oct 2013 18:10:53 -0600 Message-ID: Subject: Re: [PATCH] checkpatch: Add check for sscanf without return use To: Joe Perches Cc: Andrew Morton , Andy Whitcroft , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 22 On Mon, Oct 7, 2013 at 6:03 PM, Joe Perches wrote: > On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote: >> On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches wrote: >> >> > Naked use sscanf can be troublesome. >> >> It would be helpful to expand on "troublesome"? > > Dunno, you either know or the couple of paragraphs > it takes to explain with examples won't really be > too helpful in a commit log. It would be helpful to me, since I don't write code with sscanf every day. A URL to an LKML description or something would be enough if the commit log size is the concern. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/