Message-ID: <1381192140.2081.235.camel@joe-AO722>
Subject: Re: [PATCH] checkpatch: Add check for sscanf without return use
From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>
Date: Mon, 07 Oct 2013 17:29:00 -0700
In-Reply-To: <CAErSpo75uQL5woms175LR4KCAmqT_SWpQcXGdbKccgVPdh6xhg@mail.gmail.com>
References: <1381189523.2081.225.camel@joe-AO722>
	 <20131007165626.be437f74a4ba39e2be21af55@linux-foundation.org>
	 <1381190594.2081.228.camel@joe-AO722>
	 <CAErSpo75uQL5woms175LR4KCAmqT_SWpQcXGdbKccgVPdh6xhg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1302
Lines: 35

On Mon, 2013-10-07 at 18:10 -0600, Bjorn Helgaas wrote:
> On Mon, Oct 7, 2013 at 6:03 PM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote:
> >> On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches <joe@perches.com> wrote:
> >>
> >> > Naked use sscanf can be troublesome.
> >>
> >> It would be helpful to expand on "troublesome"?
> >
> > Dunno, you either know or the couple of paragraphs
> > it takes to explain with examples won't really be
> > too helpful in a commit log.
> 
> It would be helpful to me, since I don't write code with sscanf every
> day.  A URL to an LKML description or something would be enough if the
> commit log size is the concern.

I sent a V2 patch to Andrew and mm using this commit log:

Naked use sscanf can be troublesome because the pointed
to variables may not have been set.

Add a warning when the sscanf return value is not used.

Signed-off-by: Joe Perches <joe@perches.com>
---
V2: Use the $Compare variable instead of just == or !=
    There are some tests that use < and >


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/