Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223Ab3JHIJq (ORCPT ); Tue, 8 Oct 2013 04:09:46 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40739 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717Ab3JHIJl (ORCPT ); Tue, 8 Oct 2013 04:09:41 -0400 Date: Tue, 8 Oct 2013 09:09:08 +0100 From: Russell King - ARM Linux To: Ben Dooks Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Dave Martin , tony@atomide.com, nm@ti.com, aaro.koskinen@iki.fi, pdeschrijver@nvidia.com, linux-kernel@vger.kernel.org, =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , santosh.shilimkar@ti.com, pavel@ucw.cz, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Message-ID: <20131008080908.GA25039@n2100.arm.linux.org.uk> References: <20130904124303.GA2369@localhost.localdomain> <201309080943.30542@pali> <5253B08C.4020305@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5253B08C.4020305@codethink.co.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2578 Lines: 63 On Tue, Oct 08, 2013 at 09:13:16AM +0200, Ben Dooks wrote: > On 08/09/13 09:43, Pali Roh?r wrote: >> Here is new version (v4) of omap secure part patch: >> >> Other secure functions omap_smc1() and omap_smc2() calling instruction smc #0 >> but Nokia RX-51 board needs to call smc #1 for PPA access. >> >> Signed-off-by: Ivaylo Dimitrov >> Signed-off-by: Pali Roh?r >> --- >> diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h >> index 0e72917..c4586f4 100644 >> --- a/arch/arm/mach-omap2/omap-secure.h >> +++ b/arch/arm/mach-omap2/omap-secure.h >> @@ -51,6 +51,7 @@ >> extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, >> u32 arg1, u32 arg2, u32 arg3, u32 arg4); >> extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); >> +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 pargs); >> extern phys_addr_t omap_secure_ram_mempool_base(void); >> extern int omap_secure_ram_reserve_memblock(void); >> >> diff --git a/arch/arm/mach-omap2/omap-smc.S b/arch/arm/mach-omap2/omap-smc.S >> index f6441c1..fd90125 100644 >> --- a/arch/arm/mach-omap2/omap-smc.S >> +++ b/arch/arm/mach-omap2/omap-smc.S >> @@ -1,9 +1,11 @@ >> /* >> - * OMAP44xx secure APIs file. >> + * OMAP34xx and OMAP44xx secure APIs file. >> * >> * Copyright (C) 2010 Texas Instruments, Inc. >> * Written by Santosh Shilimkar >> * >> + * Copyright (C) 2012 Ivaylo Dimitrov >> + * Copyright (C) 2013 Pali Roh?r >> * >> * This program is free software,you can redistribute it and/or modify >> * it under the terms of the GNU General Public License version 2 as >> @@ -54,6 +56,23 @@ ENTRY(omap_smc2) >> ldmfd sp!, {r4-r12, pc} >> ENDPROC(omap_smc2) >> >> +/** >> + * u32 omap_smc3(u32 service_id, u32 process_id, u32 flag, u32 pargs) >> + * Low level common routine for secure HAL and PPA APIs via smc #1 >> + * r0 - @service_id: Secure Service ID >> + * r1 - @process_id: Process ID >> + * r2 - @flag: Flag to indicate the criticality of operation >> + * r3 - @pargs: Physical address of parameter list >> + */ >> +ENTRY(omap_smc3) >> + stmfd sp!, {r4-r11, lr} >> + mov r12, r0 @ Copy the secure service ID > > I think you should save r12 in the call. Not necessary. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/