Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754917Ab3JHJxl (ORCPT ); Tue, 8 Oct 2013 05:53:41 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:34190 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488Ab3JHJxh (ORCPT ); Tue, 8 Oct 2013 05:53:37 -0400 MIME-Version: 1.0 In-Reply-To: <20131007151212.GF15365@e106331-lin.cambridge.arm.com> References: <1381151633-8576-1-git-send-email-jonas.jensen@gmail.com> <1381155034-11254-1-git-send-email-jonas.jensen@gmail.com> <20131007151212.GF15365@e106331-lin.cambridge.arm.com> Date: Tue, 8 Oct 2013 11:53:36 +0200 Message-ID: Subject: Re: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver From: Jonas Jensen To: Mark Rutland Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "vinod.koul@intel.com" , "djbw@fb.com" , "arnd@arndb.de" , "linux@arm.linux.org.uk" , devicetree@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 40 On 7 October 2013 17:12, Mark Rutland wrote: > Sorry I didn't notice this previously, but "moxa" isn't in > Documentation/devicetree/bindings/vendor-prefixes.txt (despite several > bindings using it). Could you cook up a separate patch to add an entry > for Moxa, please? Yes, I'll submit a separate patch. > Also, given the SoC is called "ART" it's a shame that we're calling this > "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent > for "moxart" in bindings though, so changing that's likely to lead to > more problems. Sorry about that, I think the "moxart" contraction was suggested and has been sticky ever since. It's at least a little appropriate because the physical chip text reads "MOXA ART" (photo): https://lh4.googleusercontent.com/-A-2FXDrObU8/UMcMc_K2vEI/AAAAAAAABwg/ldaLZ7ps1P4/w1331-h998-no/UC-7112-LX-picture4.jpg Currently three drivers in linux-next use the name with accompanying device tree bindings. Considering the amount of patches required, can we keep the name, please? > Sorry for yet more pendantry, but could we instead have: > > - interrupts: Should contain an interrupt-specifier for the sole > interrupt generated by the device. Fixed in v11. Regards, Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/