Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 23 Oct 2002 05:20:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 23 Oct 2002 05:20:27 -0400 Received: from twilight.ucw.cz ([195.39.74.230]:60351 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id ; Wed, 23 Oct 2002 05:20:25 -0400 Date: Wed, 23 Oct 2002 11:26:28 +0200 From: Vojtech Pavlik To: Osamu Tomita Cc: "'Vojtech Pavlik '" , "'LKML '" Subject: Re: [PATCH][RFC] add support for PC-9800 architecture (13/26) key board Message-ID: <20021023112628.F28139@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from tomita@cinet.co.jp on Wed, Oct 23, 2002 at 02:09:12PM +0900 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3205 Lines: 84 On Wed, Oct 23, 2002 at 02:09:12PM +0900, Osamu Tomita wrote: > Thanks for comments. > > -----Original Message----- > From: Vojtech Pavlik > To: Osamu Tomita > Cc: LKML; Linus Torvalds > Sent: 2002/10/22 19:43 > Subject: Re: [PATCH][RFC] add support for PC-9800 architecture (13/26) > keyboard > > > I won't merge this unless it's cleaned up, kana support either made > > generic or put into keymaps, and the below problems resolved. > > > ... no way I'll add another default keymap when now we have unified > > keycodes. And we do support japanese keycodes/keymappings. > Japanese keycodes/keymapping support! We are very happy. IMHO To realize > this, emulations include shift-state modifier are needed?? > Please point me where is source code, and we don't touch defkeymaps. Tell me what exactly you need and if it cannot be done, I'll try to implement it in a generic way. > >> diff -urN linux/drivers/char/keyboard.c > > Either there is a need for a special kanji mode changing function for > > japanese keyboards or there is not. Either way, it isn't PC-98 specific. > I think it's for emergency(or rescue) purpose. For example, system cannot > boot due to illegal kanji named file, input kenji to select one and change > it. We plan direct character code input. In kanji-mode, do convert from > hex numeric input to kanji. But not implemented yet. No problem, but this should be handled by a keymap (if possible). If not, the keymap code needs to be extended to be able to handle this. > >> +#ifndef CONFIG_PC9800 > >> #define KBD_DEFLEDS 0 > >> +#else > >> +#define KBD_DEFLEDS (1 << VC_NUMLOCK) > >> +#endif > > You want numlock on by default? > Yes. Desktop PC-9800 has Ten-key pad. But doesn't have NumLock key! > Perhaps BIOS initialize always NumLock ON. > Note book PC-9800 has NumLock key. But NumLock key never send scancode, > do change scancode internaly. Interesting. > >> static void fn_scroll_forw(struct vc_data *vc) > >> { > >> +#ifndef CONFIG_PC9800 > >> scrollfront(0); > >> +#else > >> + scrollfront(3); > >> +#endif > >> } > > Huh? > Due to our implementation of console driver. For old PC-9800, we use only > video ram. If don't, scrolling is _very_ slow. So our console can scroll > less than half lines of screen. If call with 0, screen doesn't scroll. I see. However, I believe this should be handled in your implementation of the scrolling, and not affecting keyboard.c code. > >> diff -urN linux/include/linux/logibusmouse.h > linux98/include/linux/logibusmouse.h > >> --- linux/include/linux/logibusmouse.h Tue Aug 3 01:54:29 1999 > >> +++ linux98/include/linux/logibusmouse.h Fri Aug 17 22:15:13 2001 > > Hmm, this file isn't used at all in 2.5. Why patching it? > IMHO Those (pc_keyb.h too) are remaining to compile user mode application. > I think it's a very rare, but .... pc_keyb.h maybe. logibusmouse.h definitely not, no application is supposed to use those defines. -- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/