Message-ID: <1381229421.15686.17.camel@marge.simpson.net>
Subject: Re: perf: perf sched lat segfault - bisected
From: Mike Galbraith <bitbucket@online.de>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Tue, 08 Oct 2013 12:50:21 +0200
In-Reply-To: <CABPqkBSpTPttig8uKdR2KJba8rwOe3P1sKPjkVizVGH=H+w-9Q@mail.gmail.com>
References: <1381221715.15686.3.camel@marge.simpson.net>
	 <CABPqkBRMa7rawfvQ2Sunc2tr87s_WqT_7GYac6+x=SNZoJSueg@mail.gmail.com>
	 <1381227252.15686.9.camel@marge.simpson.net>
	 <1381227659.15686.11.camel@marge.simpson.net>
	 <CABPqkBQD9TE7RbP-auXO060aU1QNU=RUw2QZvoF39CCqpzdC4w@mail.gmail.com>
	 <CABPqkBSpTPttig8uKdR2KJba8rwOe3P1sKPjkVizVGH=H+w-9Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 27

On Tue, 2013-10-08 at 12:36 +0200, Stephane Eranian wrote: 
> Mike,
> 
> I found the problem in perf. The tool->mmap2 pointer is NULL for sched tool.
> Let me send you a patch to fix this.

Ah, no need.  It's probably something like so, which fixed it.

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c 
index d8c51b2f263f..a60d14dd18e7 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1658,6 +1658,7 @@ static struct perf_sched sched = {
                .comm            = perf_event__process_comm,
                .lost            = perf_event__process_lost,
                .fork            = perf_sched__process_fork_event,
+               .mmap2           = perf_event__process_mmap2,
                .ordered_samples = true,
        },
        .cmp_pid              = LIST_HEAD_INIT(sched.cmp_pid),


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/