Date: Tue, 8 Oct 2013 13:59:29 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, bitbucket@online.de, acme@redhat.com,
        peterz@infradead.org, mingo@elte.hu
Subject: Re: [PATCH] perf tools: fix missing default initialization for
 tool->mmap2
Message-ID: <20131008115929.GA2303@gmail.com>
References: <20131008105016.GA2446@quad>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131008105016.GA2446@quad>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1331
Lines: 43


* Stephane Eranian <eranian@google.com> wrote:

> 
> This patch fixes a SEGFAULT bug with perf sched
> related to the new MMAP2 record type. There was
> a missing default initialization for the tool->mmap2
> pointer in perf_tool__fill_defaults().
> 
> Reproducer:
>  # perf sched record -- sleep 1
>  # perf sched lat
> 
> Reported-by: Mike Galbraith <bitbucket@online.de>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> --
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 211b325..8415c54 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -256,6 +256,8 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
>  		tool->sample = process_event_sample_stub;
>  	if (tool->mmap == NULL)
>  		tool->mmap = process_event_stub;
> +	if (tool->mmap2 == NULL)
> +		tool->mmap2 = process_event_stub;
>  	if (tool->comm == NULL)
>  		tool->comm = process_event_stub;
>  	if (tool->fork == NULL)

I think it's already fixed in tip:perf/urgent:

  6adb0b0ae26f perf tools: Add default handler for mmap2 events

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/